chore(spanner): add epsilon-greedy strategy to ReplicaSelector#12743
Open
chore(spanner): add epsilon-greedy strategy to ReplicaSelector#12743
Conversation
Add an epsilon-greedy strategy to the standard ReplicaSelector to ensure that all endpoints are used from time to time. This ensures that new endpoints that show up are also used.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces epsilon-greedy exploration to the PowerOfTwoReplicaSelector class by adding a configurable epsilon parameter and updating the selection logic. While the implementation includes parameter validation and updated unit tests, the feedback highlights that the new default epsilon of 0.1 changes the class's standard behavior compared to the previous pure Power of Two implementation. It is suggested to consider a default epsilon of 0.0 to maintain backward compatibility and avoid breaking changes to the existing selection strategy.
...e-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/PowerOfTwoReplicaSelector.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an epsilon-greedy strategy to the standard ReplicaSelector to ensure that all endpoints are used from time to time. This ensures that new endpoints that show up are also used.